-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initial call of Joomla.loadOptions() #16488
Conversation
I have tested this item ✅ successfully on 61b334a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16488. |
@Fedik i'm still getting the error. maybe there's another place you need to do that |
seems the error is here https://github.com/joomla/joomla-cms/blob/staging/media/system/js/core-uncompressed.js#L159
|
What happens if you do |
console.log(key);
console.log(Joomla.optionsStorage); results in
|
I found the problem, |
I have tested this item ✅ successfully on 9660d35 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16488. |
1 similar comment
I have tested this item ✅ successfully on 9660d35 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16488. |
RTC after two successful tests. |
Summary of Changes
This patch fix an initial call of Joomla.loadOptions() when page do not contain the Script options, which could lead to JavaScript error.
Testing Instructions
Use latest staging,
Add in to index.php of Isis template:
And open "Control panel" page.
Expected result
You see alert "Works!"
Actual result
You see alert "Error!"
Documentation Changes Required
none